Merged
Conversation
* Add a design dock for rosbag2 handling of clock/simtime Signed-off-by: Emerson Knapp <eknapp@amazon.com>
…os2#689) * Initial PlayerClock integration - functionality unchanged * Create PlayerClock, a pure virtual interface with `now()`, and `sleep_until()` for Player to use to control timing of message playback * TimeControllerClock implementation of PlayerClock * Removes time handling from `Player` in favor of using this new class Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Add /clock publishing to Player Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
hayato-m126
approved these changes
Apr 22, 2021
hayato-m126
left a comment
There was a problem hiding this comment.
このブランチをbuild & sourceして、clockが入っていないbagを
ros2 bag play inbag --clock 40
とすることで/clockが出てくることを確認した。また、--clockをつけないときは/clockが出ないことも確認した。
このplayを使用して、logging_simulator.launchでROS_TIMEが進んで、シミュレーションができるところまで確認出来た。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is ready for review. Please test with a rosbag whether clock topic is published when --clock option is added during ros2 bag play.
I'm also concerned whether I should push it to the emersonknapp/backport-latest-to-foxy branch or I should clone it to tier4/main branch.