Add integer/double scale_type methods#5168
Merged
teunbrand merged 1 commit intotidyverse:mainfrom Feb 9, 2023
Merged
Conversation
teunbrand
commented
Jan 31, 2023
thomasp85
approved these changes
Feb 9, 2023
Member
thomasp85
left a comment
There was a problem hiding this comment.
LGTM - we should keep numeric in just for safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4605.
Briefly, it now has separate integer/double
scale_typemethods so that classes that inherit from those types also get recognised as continuous scales.A demo:
Created on 2023-01-31 with reprex v2.0.2