Skip to content

Should facet_grid(..., facets) be deprecated? #5189

@teunbrand

Description

@teunbrand

I think the facets argument in facet_grid() has been informally soft-deprecated for about 5 years now.

ggplot2/R/facet-grid-.r

Lines 116 to 119 in 37d9e8c

# `facets` is soft-deprecated and renamed to `rows`
if (!is.null(facets)) {
rows <- facets
}

Should the deprecation be more formalised with the {lifecycle} system, through deprecate_warn()?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions