chore: use splitseq instead of split#515
Merged
tobiasehlert merged 1 commit intomainfrom Sep 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes string splitting operations by replacing strings.Split with strings.SplitSeq across three files handling creature loot parsing, guild information processing, and world quest titles. The change also updates the corresponding loop iteration patterns from explicit slice iteration to range iteration over the sequence.
Key changes:
- Replace
strings.Splitwithstrings.SplitSeqfor string parsing operations - Update loop iteration from
for _, item := range slicetofor item := range sequence - Maintain existing filtering logic for empty strings and data processing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/TibiaWorldsWorld.go | Updated world quest titles parsing to use SplitSeq |
| src/TibiaGuildsGuild.go | Updated guild information line processing to use SplitSeq |
| src/TibiaCreaturesCreature.go | Updated creature loot list parsing to use SplitSeq |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how string splitting is performed in several functions by replacing usages of
strings.Splitwithstrings.SplitSeq. The change affects list parsing logic in creature loot lists, guild information, and world quest titles, likely to improve handling of input sequences or edge cases. The iteration style in the affected loops is also updated for consistency with the new splitting function.rel #453