fix: omit character deaths_truncated if false#464
Merged
tobiasehlert merged 1 commit intomainfrom Apr 3, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=======================================
Coverage 80.29% 80.29%
=======================================
Files 22 22
Lines 3694 3694
=======================================
Hits 2966 2966
Misses 587 587
Partials 141 141 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to omit the "deaths_truncated" field from the JSON output when it is false by adding the "omitempty" tag.
- Modified the JSON tag for DeathsTruncated in the Character struct
- Ensures that the field is only included when its value is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor change to the
src/TibiaCharactersCharacter.gofile. The change involves modifying theDeathsTruncatedfield in theCharacterstruct to be optional in the JSON output.src/TibiaCharactersCharacter.go: Changed theDeathsTruncatedfield in theCharacterstruct to include theomitemptytag, making it optional in the JSON output.