Skip to content

build with 8.8.1#34

Merged
23Skidoo merged 1 commit intohaskell-github-trust:masterfrom
dten:ghc8.8
Mar 15, 2020
Merged

build with 8.8.1#34
23Skidoo merged 1 commit intohaskell-github-trust:masterfrom
dten:ghc8.8

Conversation

@dten
Copy link
Copy Markdown
Contributor

@dten dten commented Nov 3, 2019

No description provided.

@jamesthompson
Copy link
Copy Markdown

jamesthompson commented Jan 14, 2020

It would be great to get this merged so stackage nightly picks it up soon. Thanks for doing the work @dten and thanks @tibbe for the excellent library and maintenance!

@23Skidoo
Copy link
Copy Markdown
Collaborator

23Skidoo commented Jan 14, 2020

I'll cut a new release this week.

YoEight
YoEight reviewed Feb 15, 2020
View reviewed changes
ekg-core.cabal
build-depends:
ghc-prim < 0.6,
base >= 4.6 && < 4.13,
base >= 4.6 && < 4.14,
Copy link
Copy Markdown

@YoEight YoEight Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do <5 instead?

Copy link
Copy Markdown
Collaborator

@23Skidoo 23Skidoo Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since we can't know that it's safe.

@YoEight
Copy link
Copy Markdown

YoEight commented Feb 15, 2020

Hello @23Skidoo, could you cut a new release, please?

@23Skidoo
Copy link
Copy Markdown
Collaborator

23Skidoo commented Feb 17, 2020

Sorry, completely forgot about this. Will do.

@YoEight
Copy link
Copy Markdown

YoEight commented Feb 17, 2020

Thank you @23Skidoo

@ejconlon ejconlon mentioned this pull request Feb 19, 2020
Closed
ejconlon
ejconlon reviewed Feb 19, 2020
View reviewed changes
.travis.yml
- rm -rfv $CABALHOME/packages/head.hackage
matrix:
include:
- compiler: ghc-8.8.1
Copy link
Copy Markdown

@ejconlon ejconlon Feb 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.8.2 now? Or 8.8.3?

This was referenced Feb 19, 2020
Merged
Merged
@YoEight
Copy link
Copy Markdown

YoEight commented Feb 24, 2020

Hello @23Skidoo, do you think you can cut a release this week? Thank you for your time.

@ejconlon
Copy link
Copy Markdown

ejconlon commented Mar 5, 2020

@23Skidoo Friendly ping for a new release! I also have a few open PRs on the subprojects for this same migration. If you need maintenance help I would be happy to pitch in.

@TravisWhitaker TravisWhitaker mentioned this pull request Mar 6, 2020
Closed
@TravisWhitaker
Copy link
Copy Markdown
Contributor

TravisWhitaker commented Mar 6, 2020

Who is the current maintainer of this package, and what is necessary to get this merged?

@YoEight
Copy link
Copy Markdown

YoEight commented Mar 11, 2020

I start to worry about @23Skidoo, hope everything is ok.

@23Skidoo 23Skidoo merged commit fe58b2b into haskell-github-trust:master Mar 15, 2020
@23Skidoo
Copy link
Copy Markdown
Collaborator

23Skidoo commented Mar 15, 2020

Published ekg-core-0.1.1.7 on Hackage. Also, @ejconlon is now an additional maintainer.

@ejconlon
Copy link
Copy Markdown

ejconlon commented Mar 16, 2020

Thank you! I am working on getting it back into Stackage nightlies now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@23Skidoo 23Skidoo 23Skidoo left review comments

+2 more reviewers

@ejconlon ejconlon ejconlon left review comments

@YoEight YoEight YoEight left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dten @jamesthompson @23Skidoo @YoEight @ejconlon @TravisWhitaker