Skip to content

Update to the new GHC.Stats API#23

Merged
23Skidoo merged 1 commit intohaskell-github-trust:masterfrom
RyanGlScott:master
Feb 27, 2018
Merged

Update to the new GHC.Stats API#23
23Skidoo merged 1 commit intohaskell-github-trust:masterfrom
RyanGlScott:master

Conversation

@RyanGlScott
Copy link
Copy Markdown
Contributor

This uses CPP inside of registerGcMetrics to use the RTSStats-based API in base-4.10 and later, falling back to the old GCStats-based API on older versions of base. This is necessary to make ekg-core build on GHC 8.4, where the old GCStats-based API has been removed.

Fixes #19.

@23Skidoo
Copy link
Copy Markdown
Collaborator

Nice! Will review later today.

Copy link
Copy Markdown
Collaborator

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@23Skidoo 23Skidoo merged commit 11b06aa into haskell-github-trust:master Feb 27, 2018
@23Skidoo
Copy link
Copy Markdown
Collaborator

Merged, thanks!

@23Skidoo
Copy link
Copy Markdown
Collaborator

Released ekg-core-0.1.1.4 on Hackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants