manager: Refactor manager screens to unified UiState and actions#3283
Merged
Conversation
- Move preference persistence and initialization (system apps and primary user app filters) from `SuperUserScreen` to `SuperUserViewModel`. - Introduce `initializePreferences`, `toggleShowSystemApps`, and `toggleShowOnlyPrimaryUserApps` in `SuperUserViewModel` to encapsulate state logic and `SharedPreferences` access. - Remove `SuperUserUtils.kt` and consolidate application grouping and sorting logic. - Simplify `SuperUserScreen` by delegating preference toggles and initialization to the ViewModel. - Remove `Parcelable` implementation and `@Parcelize` from `GroupedApps` to simplify the data model. - Clean up unused imports and streamline state observation in the SuperUser screen. Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
- Remove unused imports, including `mutableIntStateOf`, `rememberSaveable`, `KernelSUApplication`, and various unused icons and service connection components. - Clean up unnecessary XML namespaces and `tools:targetApi` attributes in manifest and theme files. - Refactor `FilterNumber` logic to use a range check for better readability. - Explicitly define `androidCompileNdkVersion` as a String in the build configuration. - Simplify `ConfirmDialogVisualsImpl` instantiation by using named arguments. - Minor cleanup of state initialization and unused variables across `InstallScreen` and `MainActivity`. Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
- Add `Arrangement.spacedBy(4.dp)` to the `Column` containing status tags (e.g., User ID) in the `AppProfileMaterial` list item to prevent overlapping and improve visual separation. Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
Collaborator
|
解决一下冲突吧 |
Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
Contributor
Author
合好了 |
Collaborator
|
要顺便pick一下这三个吗,不想多开一个pr |
idk why material so wierd
- Update `searchContent` to use `BoxScope` instead of `ColumnScope` to allow for overlaying components. - Integrate `SnackbarHost` within the search view's content area using `LocalSnackbarHost`. - Configure the snackbar with `imePadding` and `navigationBarsPadding` to ensure visibility above the software keyboard and system bars. - Wrap search results and the snackbar in a `Box` to manage alignment and stacking within the expanded search interface.
Collaborator
|
现在这个 searchbar 漏了个horizontal window insets, 你看你不能加,还是晚点我写 |
Collaborator
…nature - Update `SearchBar` component to pass `bottomPadding` to its `searchContent` lambda, ensuring correct inset handling within search results. - Refactor `ExpandedFullScreenContainedSearchBar` to exclude bottom insets from the container and manually calculate them for the content. - Update `ModuleMaterial`, `ModuleRepoMaterial`, and `SuperUserMaterial` to consume the new `bottomPadding` parameter in their search implementations. - Standardize bottom padding calculation in `ModuleRepoList` to use a provided `Dp` value instead of accessing `WindowInsets` directly. - Ensure search result lists across Module, Repo, and SuperUser screens properly account for navigation bar spacing when using the search overlay.
- Extract `SendLogBottomSheet` from `SettingsMaterial` into a standalone component in `ui.component.material`. - Modularize log saving and sharing logic, including file provider URI generation and activity result handling. - Improve UI consistency by using `FilledIconButton` and standardizing spacing/alignment within the bottom sheet. - Simplify `SettingsMaterial` by replacing inline `ModalBottomSheet` logic with the new `SendLogBottomSheet` component. - Add haptic feedback to log action buttons.
Collaborator
|
还有啥要改的么 |
YuKongA
approved these changes
Mar 13, 2026
Collaborator
Collaborator
|
SendLogDialog 是不是没用了 |
Collaborator
我看看 |
Collaborator
已解决 |
KOWX712
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UiState + Actions, shared by both Material and Miuix implementations.