⬆ Bump Starlette to version 0.22.0 to fix bad encoding for query parameters in TestClient#5659
Conversation
|
📝 Docs preview for commit d42a417 at: https://6377916021146403d9d10c6f--fastapi.netlify.app |
iudeen
left a comment
There was a problem hiding this comment.
Nice.
And thanks for the test too :)
|
This will be great for the fix on GZipMiddleware too! |
|
Thank you @azogue ! I spent forever tracking back a broken test to this issue ! Is there something missing for this PR to be merged ? |
@lovasoa, I don't know :( If there is, I could do it if pointed to 🥺 Release notes are filled with GH Actions, I think, and there is no 'milestone' tracking to add it for the next patch I suppose it will be merged soon 🤞 We are using fastAPI in production with 0.85.1, waiting for the fix to update it, after adapting the test suite with the TestClient change. The only thing I would do different is to unpin the |
0.22.0 to fix bad encoding for query parameters in TestClient
@azogue I would be in favor of that too, but you know that means |
Update
starletteto v0.22.0 to fix issue withTestClientdoing an extraunquotein the URL query(Kludex/starlette#1952 and Kludex/starlette#1953), introduced with the (tests)-Breaking change in v0.21.0 with the swap from
requests.Sessiontohttpx.Clientfor theTestClientcloses #5646