Skip to content

Conversation

@DevSpace88
Copy link

Hi, I had some time and added a german translation for the file docs/de/docs/tutorial/path-params.md

I have some points, where I am not sure how to deal with the translation:

  • Even though in german grammar, you would usually only use dashes after 3 single words put together into one word, I used it on "Pfad-Parameter" and "Pfad-Operationen" anyway. The readibility seams better than "Pfadparameter" and "Pfadoperation", also this style was already used in another PR. But people can debate this of course. On the other hand I used the correct "Pfadkonversion". Because here I didn't felt the readibility was affected very much, and actually better than with a dash, but that is really just a gut feeling and I can't explain it logically.

  • In general I am wondering which words to actually translate, because I'm not sure if in Germany actually anyone translates every single word in the IT context, because I just use the english version in most cases and I guess most people I know too. I think I would rather use path parameter than Pfad-Parameter for instance.

Anyway, I hope this is somewhat helpful and I'm thrilled to contribute at least a little bit for this amazing framework. Peace.

@tiangolo
Copy link
Member

📝 Docs preview for commit 530edef at: https://8965573c.fastapitiangolo.pages.dev

@DevSpace88
Copy link
Author

closing this since nilslindemann's translation already got merged

@DevSpace88 DevSpace88 closed this Oct 6, 2023
@nilslindemann
Copy link
Contributor

nilslindemann commented Oct 13, 2023

@DevSpace88

closing this since nilslindemann's translation already got merged

Actually, not yet. I am very sorry that these PRs overwrapped.

You were earlier with this PR, so I have to blame myself for not checking before I translated.

If you insist, I will close my PR (also did this with the two PRs by fhabers21) and you can reopen yours.

Alternatively, we can keep it as it is, under the promise that you are not mad with me for messing up.

nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review lang-all Translations lang-de German translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants