Skip to content

Commit ff4f405

Browse files
committed
coderabbit feedback about having a bin, can't bin that feedback can we?
1 parent 2ac4e87 commit ff4f405

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,13 @@ build:
2424
# Build release version (optimised)
2525
build-release:
2626
@echo "Building olla $(VERSION) for release..."
27+
@mkdir -p bin
2728
@CGO_ENABLED=0 go build $(LDFLAGS) -a -installsuffix cgo -o bin/olla$(shell go env GOEXE) .
2829

2930
# Platform-specific validation (used by CI - builds both archs for current OS but runs only AMD64)
3031
validate-linux:
3132
@echo "Building and testing Linux binaries..."
33+
@mkdir -p bin
3234
@CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build $(LDFLAGS) -o bin/olla-linux-amd64 .
3335
@CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build $(LDFLAGS) -o bin/olla-linux-arm64 .
3436
@echo "Testing Linux AMD64 binary..."
@@ -38,6 +40,7 @@ validate-linux:
3840

3941
validate-darwin:
4042
@echo "Building and testing macOS binaries..."
43+
@mkdir -p bin
4144
@CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build $(LDFLAGS) -o bin/olla-darwin-amd64 .
4245
@CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build $(LDFLAGS) -o bin/olla-darwin-arm64 .
4346
@echo "Testing macOS binary..."
@@ -52,6 +55,7 @@ validate-darwin:
5255

5356
validate-windows:
5457
@echo "Building and testing Windows binaries..."
58+
@mkdir -p bin
5559
@CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build $(LDFLAGS) -o bin/olla-windows-amd64.exe .
5660
@CGO_ENABLED=0 GOOS=windows GOARCH=arm64 go build $(LDFLAGS) -o bin/olla-windows-arm64.exe .
5761
@echo "Testing Windows AMD64 binary..."
@@ -72,6 +76,7 @@ validate-windows:
7276
# Use the OS-specific targets (validate-linux, etc) to test execution
7377
validate-all-platforms:
7478
@echo "Building all platforms (6 targets)..."
79+
@mkdir -p bin
7580
@echo "Linux AMD64..."
7681
@CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build $(LDFLAGS) -o bin/olla-linux-amd64 .
7782
@echo "Linux ARM64..."

0 commit comments

Comments
 (0)