Merged
Conversation
- Refined `.gitignore` to exclude additional files and directories. - Upgraded Visual Studio solution to version 17 and added unit test project. - Improved `LocalNotificationCenter` to clear large image binaries. - Made `Binary` property in `NotificationImage` nullable for better handling. - Enhanced `HasValue` property to safely check for null binaries. - Added assembly attribute for internal visibility in unit tests. - Introduced global using directives for cleaner code. - Updated unit test project to target .NET 8.0 with necessary package references. - Added `dotnet_logo.png` for testing resources. - Created new unit tests for serialization logic and image handling. - Updated `xunit.runner.json` to include the latest schema.
- Removed unnecessary namespaces from GlobalUsing.cs. - Enhanced documentation in LocalNotificationCenterTests.cs. - Introduced new test for clearing large image binaries. - Modified existing tests for clarity and correctness. - Added new test for NotificationImage file path validation. - Updated serializer handling for null NotificationImage.
thudugala
approved these changes
May 6, 2025
Closed
Contributor
Author
|
Hi @thudugala, Just wanted to gently nudge on the possibility of a new release that includes the fix from this recently merged PR. hopefully this resolves a high-impact crash affecting about 7% of our user sessions. A release, even a pre-release, would be hugely beneficial for us. We're happy to help test and monitor. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initial Unit Testing project setup, includes
NotificationImageTests&LocalNotificationCenterTests, also attempt to resolve #477 with additional null checking for theNotificationImage.csBinaryproperty.Why are we doing this? Any context or related work?