Skip to content

Fix azure build pipeline for macOS#393

Merged
thsmi merged 1 commit intothsmi:masterfrom
tessus:fix/macos-pipeline
Sep 13, 2020
Merged

Fix azure build pipeline for macOS#393
thsmi merged 1 commit intothsmi:masterfrom
tessus:fix/macos-pipeline

Conversation

@tessus
Copy link
Copy Markdown
Contributor

@tessus tessus commented Sep 13, 2020

On macOS we have to use zip, because yazl errors out at symbolic links.

@tessus tessus mentioned this pull request Sep 13, 2020
Closed
2 tasks
@tessus
Copy link
Copy Markdown
Contributor Author

tessus commented Sep 13, 2020

Apparently there is an eslint error, but I don't see what the problem is. I tested this locally and it works.

@tessus
Copy link
Copy Markdown
Contributor Author

tessus commented Sep 13, 2020 

[tessus@epsilon3 0 ~/work/sieve fix/macos-pipeline {tessus/fix/macos-pipeline}|✔]$ node_modules/gulp/bin/gulp.js app:zip-macos
(node:42904) ExperimentalWarning: The fs.promises API is experimental
[15:32:04] Using gulpfile ~/data/work/sieve/gulpfile.js
[15:32:04] Starting 'app:zip-macos'...
[15:32:04] Starting 'packageDefinition'...
[15:32:04] Finished 'packageDefinition' after 18 ms
[15:32:04] Starting 'packageLicense'...
[15:32:04] Starting 'packageIcons'...
[15:32:04] Starting 'packageCodeMirror'...
[15:32:04] Starting 'packageBootstrap'...
[15:32:04] Starting 'packageLibManageSieve'...
[15:32:04] Starting 'packageLibSieve'...
[15:32:04] Starting 'packageManageSieveUi'...
[15:32:04] Starting 'packageKeytar'...
[15:32:04] Finished 'packageLicense' after 95 ms
[15:32:05] Finished 'packageKeytar' after 121 ms
[15:32:05] Finished 'packageIcons' after 123 ms
[15:32:05] Finished 'packageBootstrap' after 152 ms
[15:32:05] Finished 'packageLibManageSieve' after 174 ms
[15:32:05] Finished 'packageCodeMirror' after 182 ms
[15:32:05] Finished 'packageManageSieveUi' after 262 ms
[15:32:05] Finished 'packageLibSieve' after 421 ms
[15:32:05] Starting 'packageSrc'...
[15:32:05] Finished 'packageSrc' after 43 ms
[15:32:05] Starting 'packageMacOS'...
Packaging app for platform mas x64 using electron v9.1.2
WARNING: signing is required for mas builds. Provide the osx-sign option, or manually sign the app later.
[15:32:07] Finished 'packageMacOS' after 1.94 s
[15:32:07] Starting 'packageKeytarMacOS'...
[15:32:07] Finished 'packageKeytarMacOS' after 12 ms
[15:32:07] Starting 'zipMacOS'...
[15:32:07] Compressing files /Users/tessus/data/work/sieve/build/electron/out/sieve-mas-x64/sieve.app
[15:32:07] Creating sieve-0.5.2-mas-x64.zip
[15:32:13] Finished 'zipMacOS' after 6.49 s
[15:32:13] Finished 'app:zip-macos' after 8.93 s

@tessus
Copy link
Copy Markdown
Contributor Author

tessus commented Sep 13, 2020

Found the problem.

@tessus
fix azure build pipeline for macOS
cd0e9ba 
On macOS we have to use zip, because yazl errors out at symbolic links.
@thsmi thsmi changed the title fix azure build pipeline for macOS Fix azure build pipeline for macOS Sep 13, 2020
@thsmi thsmi linked an issue Sep 13, 2020 that may be closed by this pull request
Official support for macOS #313
Closed
2 tasks
@thsmi
Copy link
Copy Markdown
Owner

thsmi commented Sep 13, 2020

Thank you, The automatic build for the pull request created the first artifact:

https://dev.azure.com/thsmi/1164eec3-b870-4973-8110-5e275d208aac/_apis/build/builds/9280/artifacts?artifactName=Zip%20-%20macOS%20Application&api-version=6.0&%24format=zip

@thsmi thsmi merged commit 52b190d into thsmi:master Sep 13, 2020
@tessus
Copy link
Copy Markdown
Contributor Author

tessus commented Sep 13, 2020

created the first artifact:

Yep, I saw that earlier. I've tested this already. Seems to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Official support for macOS

2 participants

@tessus @thsmi