Skip to content

Add meta endpoints (health, version), some other improvements#28

Merged
thoven87 merged 2 commits intothoven87:mainfrom
sersoft-gmbh:feature/meta-routes
Jun 11, 2025
Merged

Add meta endpoints (health, version), some other improvements#28
thoven87 merged 2 commits intothoven87:mainfrom
sersoft-gmbh:feature/meta-routes

Conversation

@ffried
Copy link
Copy Markdown
Contributor

@ffried ffried commented Jun 10, 2025

Mainly, this adds support for the meta endpoints /health and /version.

While doing so, I also made the following other improvements:

  • Reduce number of implicitly and force unwrapped optionals by using non-optional conversion between String <-> Data as well as #require in tests.
  • Reduce code duplication by centralizing metadata serialization
    • There are more opportunities for improvements here, but that was a rather low hanging fruit
  • Performance improvements:
    • Retried requests are now re-used instead of being recreated from scratch
    • Reading response bodies now uses optimized APIs of ByteBuffer etc.
    • TimeOuts are no longer serialized into headers only to be parsed again - they are now passed directly to the execution methods instead

@thoven87
Copy link
Copy Markdown
Owner

thoven87 commented Jun 10, 2025

Mainly, this adds support for the meta endpoints /health and /version.

While doing so, I also made the following other improvements:

  • Reduce number of implicitly and force unwrapped optionals by using non-optional conversion between String <-> Data as well as #require in tests.

  • Reduce code duplication by centralizing metadata serialization

    • There are more opportunities for improvements here, but that was a rather low hanging fruit
  • Performance improvements:

    • Retried requests are now re-used instead of being recreated from scratch
    • Reading response bodies now uses optimized APIs of ByteBuffer etc.
    • TimeOuts are no longer serialized into headers only to be parsed again - they are now passed directly to the execution methods instead

Thanks @ffried PR looks good. Can you run swift format . --in-place --recursive at the root of the project and push the commit?

@ffried
Copy link
Copy Markdown
Contributor Author

ffried commented Jun 11, 2025

@thoven87 Sure, done!

@thoven87 thoven87 merged commit 93d8382 into thoven87:main Jun 11, 2025
3 checks passed
@thoven87
Copy link
Copy Markdown
Owner

@thoven87 Sure, done!

Thanks! I will cut a release later today.

@ffried ffried deleted the feature/meta-routes branch June 12, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants