fix inline documentation about is_greater_than in validate_comparison_of matcher#1616
Merged
vsppedro merged 1 commit intothoughtbot:mainfrom Feb 26, 2024
Conversation
vsppedro
approved these changes
Feb 25, 2024
Collaborator
|
Hey, @jeduardo824, great find! I noticed another one at Could you include this in your pull request too? Thanks a lot for your contribution! |
22c25d6 to
7ae5718
Compare
Contributor
Author
Job done! |
matsales28
approved these changes
Feb 26, 2024
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the initial example the inline documentation of the validate_comparison_of matcher. In the example, the matcher is using
greater_than(...)in the tests, but it is actuallyis_greater_than(...).