Lazy load ActionController and Routing matchers for ActionController::TestCase#1613
Merged
matsales28 merged 1 commit intothoughtbot:mainfrom Mar 15, 2024
Merged
Conversation
0218d01 to
7c2bae6
Compare
vsppedro
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up two
on_loadhooks to include theActionControllerandRoutingmatchers modules intoActionController::TestCase. They run only whenActionController::TestCaseis loaded rather than immediately whenever theintegrate_withmethod is called.This change should improve app booting performance by delaying the inclusion of the matchers until they are actually needed.