adds failure_message_when_negated to have_secure_password_matcher#1593
Merged
vsppedro merged 1 commit intothoughtbot:mainfrom Dec 23, 2023
Conversation
vsppedro
reviewed
Dec 23, 2023
Co-authored-by: Matheus Dutra Lima <kutomore@gmail.com>
c3e2b81 to
4b04a44
Compare
Contributor
Author
Good idea. Done |
Collaborator
|
Thank you for your contribution, @amalrik! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1187
credits goes to @Kutomore Im just adding missing specs to his solution on a new PR because I cant override PR #1192