fix: catch ruby3.3 format NoMethodError message#1579
Merged
matsales28 merged 1 commit intothoughtbot:mainfrom Dec 1, 2023
Merged
fix: catch ruby3.3 format NoMethodError message#1579matsales28 merged 1 commit intothoughtbot:mainfrom
matsales28 merged 1 commit intothoughtbot:mainfrom
Conversation
ruby3.3.0dev changes the error messages on NoMethodError with the following commit / issue: ruby/ruby#6950 https://bugs.ruby-lang.org/issues/18285 So to catch this new NoMethodError message, modify regex accordingly. Fixes thoughtbot#1578 .
matsales28
approved these changes
Nov 10, 2023
Member
matsales28
left a comment
There was a problem hiding this comment.
LGTM! We currently do not support Ruby 3.3, but this shouldn't affect the application, so I'm okay with it.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby3.3.0dev changes the error messages on NoMethodError with the following commit / issue:
ruby/ruby#6950
https://bugs.ruby-lang.org/issues/18285
So to catch this new NoMethodError message, modify regex accordingly.
Fixes #1578 .