feat: When an unrelated error is seen with negated allow_value, give a hint#1570
Merged
matsales28 merged 3 commits intothoughtbot:mainfrom Dec 8, 2023
Merged
Conversation
In cases when an unrelated error is seen that makes `allow_value` fail, the validation message was using the erroneous text "but it was valid instead". This changes the validation message to indicate which attribute(s) actually failed validation.
9e58506 to
6b6b227
Compare
6b6b227 to
7304b8f
Compare
This spec was failing because the polymorphic association was not optional, that was causing it to have an error on the association and not in the attribute `severity_type` that was being validated the inclusion. Setting the association as optional fixed the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To clean out some old PRs, I'm trying to push and merge some changes so we can close them. This is basically a copy of #1238, making the adjustments suggested on the code view. All the credit from this PR goes to @antifun.
I am quoting the PR owner.
Closes: #919 and #1238