Removing array_column? helper from validate_absence_of_matcher#1562
Merged
matsales28 merged 1 commit intothoughtbot:mainfrom Dec 26, 2023
Conversation
Member
|
@jarenas9539 sorry for taking a long time to review. Do you mind rebasing your PR? It looks good to me. |
fef79d2 to
1f5001d
Compare
Contributor
Author
|
Thanks @matsales28, already rebased 👍. I hope next year I'll be able to extend #1560 approach to other related matchers. |
matsales28
approved these changes
Dec 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1560,
array_column?helper was extracted to basevalidation_matcherso this helper definition is no longer required on this matcher.