feat: Implement of_sql_type qualifier on have_db_column matcher#1555
Merged
matsales28 merged 1 commit intothoughtbot:mainfrom May 2, 2023
Merged
Conversation
This commit intends to implement the `of_sql_type` qualifier on the `have_db_column` matcher. The implementation is quite simple and is following the pattern of the `HaveDbColumnMatcher` class. This commit closes this issue thoughtbot#1432
b5aec5e to
4de0305
Compare
vsppedro
approved these changes
May 1, 2023
Collaborator
|
LGTM! |
mcmire
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1432
This commit intends to implement the
of_sql_typequalifier on thehave_db_columnmatcher. The implementation is quite simple and follows the pattern of theHaveDbColumnMatcherclass.