Skip to content

Remove Ruby 2.7 support#1547

Merged
vsppedro merged 2 commits intothoughtbot:mainfrom
HeitorMC:drop-support-ruby-2.7
Mar 22, 2023
Merged

Remove Ruby 2.7 support#1547
vsppedro merged 2 commits intothoughtbot:mainfrom
HeitorMC:drop-support-ruby-2.7

Conversation

@HeitorMC
Copy link
Copy Markdown
Contributor

@HeitorMC HeitorMC commented Mar 21, 2023

Removes support for Ruby 2.6 due to EOL.

I also checked that Rails 6.0.x will hit EOL on June 1st, 2023. If you guys want to, I can remove it in this PR, or create a new one :)

@vsppedro vsppedro added this to the 6.0.0 milestone Mar 21, 2023
@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Mar 21, 2023

Thanks for working on this. I think is better to create another PR to remove Rails 6.

@HeitorMC
Copy link
Copy Markdown
Contributor Author

HeitorMC commented Mar 21, 2023

Hmmm, the rubocop is failing and I didn't change the file that it's breaking 🤔

Also, that line it's present on the main branch

shoulda-matchers/lib/shoulda/matchers/util/word_wrap.rb

Line 44 in 195153c

LIST_ITEM_REGEXP = /\A((?:[a-z0-9]+(?:\)|\.)|\*) )/.freeze

@vsppedro Do you want me to fix it, or just rerun the pipeline? 😄

@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Mar 21, 2023 •
edited
Loading

Hmmm, the rubocop is failing and I didn't change the file that it's breaking thinking

It's because this PR updates the "TargetRubyVersion" in the Rubocop file. We need to update the code according to this new version.

@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Mar 21, 2023 •
edited
Loading

I intent to merge this PR first: #1521

It will cause some conflict. If I merge yours first the other contribution would be lost. Sorry.

@HeitorMC
Copy link
Copy Markdown
Contributor Author

HeitorMC commented Mar 21, 2023

I intent to merge this PR first: #1521

It will cause some conflict. If I merge yours first the other contribution would be lost. Sorry.

Oh no problem, I was expecting that haha, don't worry!

@HeitorMC HeitorMC force-pushed the drop-support-ruby-2.7 branch from b7168fa to 1b29d6c Compare March 22, 2023 13:24
@vsppedro vsppedro merged commit fababc3 into thoughtbot:main Mar 22, 2023
@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Mar 22, 2023 •
edited
Loading

Thank you for working on this!

@vsppedro vsppedro mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsppedro vsppedro vsppedro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@HeitorMC @vsppedro