Adds Ruby 3.2 to the CI matrix. Also updates cache and checkout actions versions.#1536
Merged
vsppedro merged 1 commit intothoughtbot:mainfrom Jan 10, 2023
petergoldstein:feature/add_ruby_3_2_to_ci
Merged
Adds Ruby 3.2 to the CI matrix. Also updates cache and checkout actions versions.#1536vsppedro merged 1 commit intothoughtbot:mainfrom petergoldstein:feature/add_ruby_3_2_to_ci
vsppedro merged 1 commit intothoughtbot:mainfrom
petergoldstein:feature/add_ruby_3_2_to_ci
Conversation
… versions. To get this working I needed to: 1. Revisit gem restrictions for the Rails 7 gemfile, allowing more recent rake versions and setting the rspec-rails version to 6.x, which is appropriate for Rails 7 2. Exclude byebug if this is Ruby 3.2 or higher I also updated the bundler version in the Rails 7 gemfile and fixed a deprecated configuration parameter in the Rubocop configuration to eliminate warnings.
vsppedro
approved these changes
Jan 10, 2023
Collaborator
|
Hi, @petergoldstein, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get this running green I needed to:
I also updated the bundler version in the Rails 7 gemfile, updated the patch versions of the other Rubies to current, and fixed a deprecated configuration parameter in the Rubocop configuration to eliminate warnings.
Everything runs green on my fork.