Skip to content

Support :uuid column type for validate_absence_of matcher#1518

Merged
vsppedro merged 5 commits intothoughtbot:mainfrom
dlupu:main
Nov 14, 2022
Merged

Support :uuid column type for validate_absence_of matcher#1518
vsppedro merged 5 commits intothoughtbot:mainfrom
dlupu:main

Conversation

@dlupu
Copy link
Copy Markdown
Contributor

@dlupu dlupu commented Oct 31, 2022

Hello,

I run into a case where I needed to make sure that an uuid column was empty but could not use validate_absence_of matcher.

It tried to set the column with "an arbitrary value" which is not a valid uuid value.

This Pull Requests attempts to fix the situation.

vsppedro
vsppedro previously approved these changes Nov 5, 2022
View reviewed changes
@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Nov 5, 2022

Hi, @dlupu, thank you very much for your contribution!

There is only one detail: rubocop detected trailing whitespace. Would be possible to fix that, please?

About the error with 3.1.2, rails_6_0 and PostgreSQL I'll take a closer look as soon as I have some time.

@vsppedro vsppedro self-requested a review November 5, 2022 13:34
@vsppedro vsppedro dismissed their stale review November 5, 2022 13:41

I did not notice the error on Test / build (3.1.2, rails_6_0, postgresql)

@dlupu
Update validate_absence_of_matcher.rb
bae5381 
Remove trailing whitespace
@dlupu
Copy link
Copy Markdown
Contributor Author

dlupu commented Nov 13, 2022 •
edited
Loading

@vsppedro sorry for the late reply.

I fixed the rubocop issue.

However, I'm surprised about the error that appears only on Test / build (3.1.2, rails_6_0, postgresql). I've cloned the code locally and run the failing test on my machine using

  • ruby 3.1.2
  • appraisal rails_6_0
  • postgresql db adapter

The tests passes ....

dlupu
dlupu commented Nov 14, 2022
View reviewed changes
Comment thread spec/unit/shoulda/matchers/active_model/validate_absence_of_matcher_spec.rb Outdated
@dlupu
Copy link
Copy Markdown
Contributor Author

dlupu commented Nov 14, 2022

@vsppedro it seems that Test / build (3.1.2, rails_6_0, postgresql) is green not. I also fixed the last rubocop issue, please trigger the CI again.

@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Nov 14, 2022

Hi @dlupu, thanks for working on this. The failure we had earlier looks like an intermittent test. It was probably not caused by your changes. I'll keep an eye on that. Thank you again!

@vsppedro vsppedro merged commit 481712b into thoughtbot:main Nov 14, 2022
@vsppedro vsppedro mentioned this pull request Dec 6, 2022
Merged
@vsppedro vsppedro mentioned this pull request Jan 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsppedro vsppedro vsppedro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlupu @vsppedro