-
Notifications
You must be signed in to change notification settings - Fork 212
Add audit logging #3425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
toastwaffle
merged 15 commits into
thought-machine:master
from
avdes96:add-logging-of-please-invocations-build-commands-and-remote-file-fetching
Oct 15, 2025
Merged
Add audit logging #3425
toastwaffle
merged 15 commits into
thought-machine:master
from
avdes96:add-logging-of-please-invocations-build-commands-and-remote-file-fetching
Oct 15, 2025
+264
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
reviewed
Oct 8, 2025
…ote file fetching
…ened long variable names, pass uuid and audit log directory as args instead of storing in log state and added doc comments
63f757e to
99502f4
Compare
toastwaffle
reviewed
Oct 10, 2025
Contributor
toastwaffle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still working on adding an e2e test?
toastwaffle
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional audit logging to Please. When audit logging is enabled (via the provision of an audit log directory), a sub-directory for each Please invocation is created, and the following information saved to the sub-directory: