Modify parse_cookies to split on first occurrence of '=' only#9
Closed
rpkyle wants to merge 1 commit intothomasp85:masterfrom
plotly:fix-cookie-handling
Closed
Modify parse_cookies to split on first occurrence of '=' only#9rpkyle wants to merge 1 commit intothomasp85:masterfrom plotly:fix-cookie-handling
rpkyle wants to merge 1 commit intothomasp85:masterfrom
plotly:fix-cookie-handling
Conversation
|
FWIW we encountered this issue in conjunction with google analytics, which creates cookies like: |
Owner
|
I've opted to use stringi instead of substituting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parse_cookiesfunction inrequest.Rattempts to split cookies on each occurrence of=; this appears to generate errors such as the following when multiple instances of=occur within a cookie:This may be reproduced by using
curlor a similar tool to pass a cookie string containing two or more=, e.g.The original lines are here:
reqres/R/request.R
Lines 437 to 445 in c69c053
This pull request proposes to modify line 440:
Since
subwill only replace the first matching=,strsplitwill split the line only once.