Add only-delete option #371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now pass `only-delete` which just deletes the comment if it exists. If it doesn't exist, it will log a message and return.
Contributor
Author
|
I'm assuming CI is failing because I'm a first-time contributor to this repo so the token doesn't have perms to comment on this PR. |
|
@thollander any chance you could have a look at this please. It's exactly what we need. Would be nice to have this included in the action. |
Owner
|
Thanks for the contribution ! |
Contributor
Author
|
Funny, I was just looking at this PR again today. We no longer use this package, but anyone can feel free to edit this or make a new PR with the suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a glance, I expected the
mode: deleteoption to just delete a comment.Instead, the
deletemode deletes comments during cleanup.This adds functionality to delete comments immediately. In order to be
backward compatible, I left the
deletemode unchanged. I addedan
only-deletemode which just deletes comments immediately.Ref: #361
cc @liamnichols