test: skip system tests requiring public access (#2717)#28
Conversation
Skips tests that attempt to assign public or authenticated user roles to IAM policies. These tests are currently failing with 403 errors due to environment permission restrictions.
Summary of ChangesHello @thiyaguk09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request temporarily disables several system tests that interact with public IAM roles for Google Cloud Storage buckets and files. The tests were consistently failing with 403 permission errors due to limitations in the current testing environment. By skipping these tests, the PR ensures the overall test suite can pass without these known failures, while clearly marking them for future re-evaluation when environment permissions are adjusted. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request skips several system tests that are failing due to permission restrictions in the test environment. The changes correctly use it.skip to disable the tests and include comments explaining the reason.
My main feedback is on the duplicated comment block across multiple tests in system-test/storage.ts. I've suggested a way to centralize the skip reason to improve maintainability.
Overall, the changes are clear and address the issue described.
| /** | ||
| * TODO: Re-enable once the test environment allows public IAM roles. | ||
| * Currently disabled to avoid 403 errors when adding 'allUsers' or | ||
| * 'allAuthenticatedUsers' permissions. | ||
| */ |
There was a problem hiding this comment.
This comment block is repeated for several skipped tests in this file. To improve maintainability and reduce duplication, consider defining a constant for the skip reason at a higher scope.
For example:
const PUBLIC_ACCESS_SKIP_REASON = 'Skipping test that requires public IAM roles due to environment restrictions. TODO: Re-enable when permissions are available.';
// ...
// ${PUBLIC_ACCESS_SKIP_REASON}
it.skip('should make a bucket public', async () => {
// ...
});This makes it easier to update the reason in one place if needed in the future.
aef4dcd
into
thiyaguk09:feat/bucket-encryption-config
Skips tests that attempt to assign public or authenticated user roles to IAM policies. These tests are currently failing with 403 errors due to environment permission restrictions.
Description
Impact
Testing
Additional Information
Checklist
Fixes #issue_number_goes_here 🦕