Add a new editor for the sectoin-report format#87
Merged
hidakatsuya merged 10 commits intothinreports:masterfrom Nov 29, 2020
Merged
Add a new editor for the sectoin-report format#87hidakatsuya merged 10 commits intothinreports:masterfrom
hidakatsuya merged 10 commits intothinreports:masterfrom
Conversation
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com> Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com>
Co-authored-by: mugi-uno <mugi.uno@gmail.com>
Co-authored-by: Katsuya HIDAKA <hidakatsuya@gmail.com>
2a682cc to
91550db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This pull request is one of the activities to support a new report type called section-report format. See Issue: Implement "New Report Type: Section Report" for the details.
Summary
This pull request adds a new editor for the section-report format proposed at the Issue: New Report Type: SectionReport.
Getting Started
Prerequisites
Launching the app for development
Examples
Some example codes (Ruby codes, templates, and output PDFs) are listed at the Issue: Implement "New Report Type: Section Report".
Policy
The section-report format specific editor
The editor we implemented only supports the section-report format and does not support the current format. This is based on the two reasons: technical and functional.
First, the technical reason is that it was difficult to add the section-report format feature to the current editor, which depends on old libraries and has very complex codebase. Therefore we implemented a new editor in a completely different architecture, which allows for future enhancements to the section-report format feature.
Secondly, the functional reasons is that adding the section-report format to the current editor would be a duplication of functionality. We can reproduce most of the layout of the current format with only the section-report format.
How to develop the original format editor and the section-report format editor
We have an idea to develop two editors in each separate directory in the current repository. The directory structure will look like this:
section_report/is the codebase of the section-report format editor, that has already been added in this PR.basic_report/is the codebase of the current format editor. The directory namings are still debatable.Implementation Status
Here is the current implementation status based on the feature concept in Issue: New Report Type: SectionReport.
Not Implemented
reference-idattributeAdditional Features
Changes for the line-height calculation
The line-height calculation method in the original editor has a problem that the result depends on the environment such as display resolution.
Therefore, the calculation method in this editor has been changed as follows:
line-height-ratio = (height calculated from the drawn text) * line-heightline-height-ratio = font-size * line-height