Skip to content

[CIT-95] Build and Test script for developer#6

Merged
PradeepKiruvale merged 5 commits intothin-edge:mainfrom
PradeepKiruvale:feature/CIT-95/build_script
Dec 4, 2020
Merged

[CIT-95] Build and Test script for developer#6
PradeepKiruvale merged 5 commits intothin-edge:mainfrom
PradeepKiruvale:feature/CIT-95/build_script

Conversation

@PradeepKiruvale
Copy link
Copy Markdown
Contributor

Signed-off-by: Pradeep K J pradeekumar.kj@softwareag.com

Signed-off-by: Pradeep K J <pradeekumar.kj@softwareag.com>
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

Comment on lines +22 to +24
- os: Raspbian32

- os: Ubuntu20.04
Copy link
Copy Markdown
Member

@rina23q rina23q Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added Raspbian32 and Ubuntu20.04 as a label of runners. Does it really work?
Don't we need "self-hosted" declaration as well as labels? I found how to specify labels on self-hosted runners. https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on

Self-hosted runners
To specify a self-hosted runner for your job, configure runs-on in your workflow file with self-hosted runner labels.

All self-hosted runners have the self-hosted label, and you can select any self-hosted runner by providing only the self-hosted label. Alternatively, you can use self-hosted in an array with additional labels, such as labels for a specific operating system or system architecture, to select only the runner types you specify.

Example
runs-on: [self-hosted, linux]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on any labels that are mentioned in the runners. It already ran, you can see the recent workflow trigger

Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for the updated commit

@PradeepKiruvale PradeepKiruvale merged commit a3f4793 into thin-edge:main Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants