Skip to content

fix: docker log plugin sample improvement#3887

Merged
albinsuresh merged 1 commit intothin-edge:mainfrom
albinsuresh:fix/docker-log-plugin-output
Dec 3, 2025
Merged

fix: docker log plugin sample improvement#3887
albinsuresh merged 1 commit intothin-edge:mainfrom
albinsuresh:fix/docker-log-plugin-output

Conversation

@albinsuresh
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh commented Dec 3, 2025 •
edited
Loading

Proposed changes

Capture docker logs command output on stderr along with stdout in the docker log plugin sample in documentation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

albinsuresh
albinsuresh commented Dec 3, 2025
View reviewed changes
docs/src/extend/log-management.md
@@ -1,5 +1,5 @@
---
title: Extensible Log Management
title: Log Management
Copy link
Copy Markdown
Contributor Author

@albinsuresh albinsuresh Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the title consistent with other articles (Firmware Management and Software Management) in the Extend thin-edge.io section.

didier-wenzek
didier-wenzek approved these changes Dec 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
744 0 3 744 100 2h25m51.523712999s

@albinsuresh albinsuresh added this pull request to the merge queue Dec 3, 2025
Merged via the queue into thin-edge:main with commit f7ad733 Dec 3, 2025
34 checks passed
@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label Dec 4, 2025
@albinsuresh albinsuresh deleted the fix/docker-log-plugin-output branch December 9, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@reubenmiller reubenmiller Awaiting requested review from reubenmiller reubenmiller is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albinsuresh @didier-wenzek @reubenmiller