fix: prevent URI percent-decoding in c8y_auth_proxy path handling#3886
Merged
rina23q merged 1 commit intothin-edge:mainfrom Dec 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
jarhodes314
reviewed
Dec 3, 2025
Contributor
jarhodes314
left a comment
There was a problem hiding this comment.
Nice fix. A couple of suggested improvements, but the changes are broadly good.
While we're fixing this, I suspect we've got a similar potential bug with the handling of query parameters, it would be good to check if that's the case and handle it similarly if so.
jarhodes314
reviewed
Dec 3, 2025
jarhodes314
approved these changes
Dec 3, 2025
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
65eadf7 to
2cbe306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
axum::extract::Pathforces any percent encoded parameters decoded, that causes a url containing encoded semicolon%3Bchanged into decoded;, and c8y responses with an error.This PR uses a workaround to avoid using
axum::extract::Path.Types of changes
Paste Link to the issue
#3884
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments