feat: add tedge-init-hsm.sh convenience script#3870
Merged
reubenmiller merged 2 commits intothin-edge:mainfrom Nov 26, 2025
Merged
feat: add tedge-init-hsm.sh convenience script#3870reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller merged 2 commits intothin-edge:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
d915793 to
87e41cf
Compare
Bravo555
reviewed
Nov 25, 2025
Member
Bravo555
left a comment
There was a problem hiding this comment.
Some inconsistencies in the tests, otherwise looks good.
tests/RobotFramework/tests/pkcs11/private_key_storage_aws.robot
Outdated
Show resolved
Hide resolved
Bravo555
approved these changes
Nov 26, 2025
Member
Bravo555
left a comment
There was a problem hiding this comment.
Feedback addressed so approving, nice clean-up of the test suite and good PKCS11 utility for users.
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
8bafb21 to
a7d4409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a convenience script to make it easier for users to initial different Hardware Security Modules (HSM) like TPM2, Nitrokey and SoftHSMs. This should make it easier to document the instructions for different HSM modules without having to go into the complexity of how to setup each, as some HSMs have some additional setup steps which could be daunting for new users.
With the introduction of the convenience script, the following changes were also included:
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments