Skip to content

fix: remove inappropriate warning on MQTT connect#3867

Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:fix/inappropriate-warning
Nov 19, 2025
Merged

fix: remove inappropriate warning on MQTT connect#3867
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:fix/inappropriate-warning

Conversation

@didier-wenzek
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek commented Nov 18, 2025

Proposed changes

Since #3823, an inappropriate warning is printed
when a non-TLS connection is established to the local broker:

$ tedge mqtt sub te/#
2025-11-18T14:47:04.179834205Z  WARN MQTT: Connecting on port 1883 for insecure MQTT using a TLS connection

This warning is inappropriate because the connection is not established over TLS: neither a client certificate nor root certificates have been configured.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Since thin-edge#3823,
an inappropriate warning is printed
when a non-TLS connection is established to the local broker:

$ tedge mqtt sub te/#
2025-11-18T14:47:04.179834205Z  WARN MQTT: Connecting on port 1883 for insecure MQTT using a TLS connection

This warning is inappropriate because the connection is *not* established over TLS:
neither a client certificate nor root certificates have been configured.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek added bug Something isn't working theme:mqtt Theme: mqtt and mosquitto related topics labels Nov 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
742 0 3 742 100 2h29m8.103718s

Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the functionality

@didier-wenzek didier-wenzek added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2025
@didier-wenzek didier-wenzek added this pull request to the merge queue Nov 19, 2025
Merged via the queue into thin-edge:main with commit fdfdc0e Nov 19, 2025
32 checks passed
@didier-wenzek didier-wenzek deleted the fix/inappropriate-warning branch November 19, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working theme:mqtt Theme: mqtt and mosquitto related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants