Skip to content

refactor: typed device topic id in tedge config#3864

Merged
albinsuresh merged 1 commit intothin-edge:mainfrom
albinsuresh:refactor/typed-device-topic-id-in-tedge-config
Nov 19, 2025
Merged

refactor: typed device topic id in tedge config#3864
albinsuresh merged 1 commit intothin-edge:mainfrom
albinsuresh:refactor/typed-device-topic-id-in-tedge-config

Conversation

@albinsuresh
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh commented Nov 18, 2025 •
edited
Loading

Proposed changes

Use typed device topic id in tedge config

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

albinsuresh
albinsuresh commented Nov 18, 2025
View reviewed changes
crates/common/tedge_config/Cargo.toml
serde = { workspace = true, features = ["rc"] }
strum = { workspace = true }
strum_macros = { workspace = true }
tedge_api = { workspace = true }
Copy link
Copy Markdown
Contributor Author

@albinsuresh albinsuresh Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this is fine.

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal, but okay. Somehow the issue is not new. tedge_config is already depending on mqtt_channel only to get some Topic and TopicFilter types. Also, tedge_api is a mix of global concepts such as EntityTopicId and mechanisms such as workflows. To fix that we would have to introduce a crate with the types used by all thin-edge components.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge_agent/src/agent.rs 0.00% 5 Missing ⚠️
crates/core/tedge_mapper/src/c8y/mapper.rs 0.00% 3 Missing ⚠️
crates/core/tedge_watchdog/src/systemd_watchdog.rs 0.00% 2 Missing ⚠️
crates/core/tedge/src/cli/connect/command.rs 0.00% 1 Missing ⚠️
...es/core/tedge_agent/src/software_manager/config.rs 0.00% 1 Missing ⚠️
crates/core/tedge_mapper/src/aws/mapper.rs 0.00% 1 Missing ⚠️
crates/core/tedge_mapper/src/az/mapper.rs 0.00% 1 Missing ⚠️
crates/extensions/c8y_mapper_ext/src/config.rs 0.00% 1 Missing ⚠️
plugins/c8y_firmware_plugin/src/lib.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
742 0 3 742 100 2h21m4.121199999s

@albinsuresh albinsuresh marked this pull request as ready for review November 18, 2025 09:36
@albinsuresh albinsuresh mentioned this pull request Nov 18, 2025
Merged
11 tasks
didier-wenzek
didier-wenzek approved these changes Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

crates/common/tedge_config/Cargo.toml
serde = { workspace = true, features = ["rc"] }
strum = { workspace = true }
strum_macros = { workspace = true }
tedge_api = { workspace = true }
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal, but okay. Somehow the issue is not new. tedge_config is already depending on mqtt_channel only to get some Topic and TopicFilter types. Also, tedge_api is a mix of global concepts such as EntityTopicId and mechanisms such as workflows. To fix that we would have to introduce a crate with the types used by all thin-edge components.

@albinsuresh albinsuresh added this pull request to the merge queue Nov 19, 2025
Merged via the queue into thin-edge:main with commit 89777a8 Nov 19, 2025
34 checks passed
@albinsuresh albinsuresh deleted the refactor/typed-device-topic-id-in-tedge-config branch November 28, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

@reubenmiller reubenmiller Awaiting requested review from reubenmiller reubenmiller is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@albinsuresh @didier-wenzek