Skip to content

feat: add dmesg log plugin#3830

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:feat-add-dmesg-plugin
Oct 24, 2025
Merged

feat: add dmesg log plugin#3830
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:feat-add-dmesg-plugin

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Oct 22, 2025

Proposed changes

Add a dmesg log plugin to the out-of-the-box features. The dmesg plugin only provide one type called "all" due to the vast differences in the dmesg implementations (e.g. busybox/bsd don't support filtering by log facility or datetime).

The plugin will attempt to call dmesg with a datetime filter, however if it fails for any reason, then dmesg will be called without any arguments (and in this case all the messages will be returned). This is due to the various implementations of dmesg.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Oct 22, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 22, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
716 0 3 716 100 2h10m28.228758s

@reubenmiller reubenmiller force-pushed the feat-add-dmesg-plugin branch from 789a292 to d14bc05 Compare October 22, 2025 15:38
@reubenmiller reubenmiller marked this pull request as ready for review October 22, 2025 15:40
@reubenmiller reubenmiller requested review from a team and rina23q as code owners October 22, 2025 15:40
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The default time range could be increased as suggested.

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added this pull request to the merge queue Oct 24, 2025
Merged via the queue into thin-edge:main with commit 7689e03 Oct 24, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants