feat: add journald log plugin#3806
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Oct 8, 2025
Merged
Conversation
reubenmiller
commented
Oct 6, 2025
| exit 1 | ||
| fi | ||
| status=0 | ||
| { systemctl list-units --type=service --no-legend --no-pager --plain || status=$?; } | awk '!/^systemd/ { sub(/\.service$/, "", $1); print $1 }' || status=$? |
Contributor
Author
There was a problem hiding this comment.
Unfortunately the pipefail option is not in the posix spec (or at least not in any recent versions), so we have to do use subshells and store the status if the systemctl command fails.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
albinsuresh
reviewed
Oct 6, 2025
Contributor
Sounds good to me. |
albinsuresh
approved these changes
Oct 7, 2025
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
5bf1712 to
fa52425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add journald log plugin which is included in the deb and rpm packages only.
The plugin includes a special log type called "all-units" which when used will return the logs for all systemd units/services. It is the equivalent to doing
journalctl -u "*". Having an option to return the logs for all units is useful when solving complex scenarios where behaviour across multiple services needs to be observed.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments