Skip to content

fix: tedge connect c8y --test works with basic auth#3793

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
rina23q:fix/3791/fix-tedge-connect-c8y-test-when-basic-auth-used
Sep 19, 2025
Merged

fix: tedge connect c8y --test works with basic auth#3793
reubenmiller merged 1 commit intothin-edge:mainfrom
rina23q:fix/3791/fix-tedge-connect-c8y-test-when-basic-auth-used

Conversation

@rina23q
Copy link
Copy Markdown
Member

@rina23q rina23q commented Sep 19, 2025

Proposed changes

tedge connect c8y --test uses SmartREST 123 and expects to receive 124 when using basic auth.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3791

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q
fix: tedge connect c8y --test works with basic auth
2d36fcf 
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@rina23q rina23q temporarily deployed to Test Pull Request September 19, 2025 10:58 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:c8y Theme: Cumulocity related topics label Sep 19, 2025
reubenmiller
reubenmiller approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (functionality and tests), though please wait for a Rust code review.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/connect/c8y.rs 0.00% 19 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
695 0 3 695 100 2h7m30.002264s

didier-wenzek
didier-wenzek approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Sep 19, 2025
Merged via the queue into thin-edge:main with commit 6fa73b8 Sep 19, 2025
51 of 52 checks passed
@rina23q rina23q deleted the fix/3791/fix-tedge-connect-c8y-test-when-basic-auth-used branch September 19, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees

No one assigned

Labels

theme:c8y Theme: Cumulocity related topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rina23q @reubenmiller @didier-wenzek