Skip to content

feat: enable cert renewal when using cloud profiles with Cumulocity#3783

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:feat-cloud-profile-cert-renewal-service
Sep 18, 2025
Merged

feat: enable cert renewal when using cloud profiles with Cumulocity#3783
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:feat-cloud-profile-cert-renewal-service

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Sep 17, 2025

Proposed changes

Add a new systemd service template to handle the certificate renewal when using a Cumulocity mapper with cloud profiles. The previous service tedge-cert-renewer@.service isn't able to support cloud profiles as the template variable (the part after the @ sign) is used for the mapper type, and not the cloud profile name.

The new tedge-cert-renewer-c8y@.timer unit (not the -c8y before the @ sign!) will be automatically activated when the tedge-mapper-c8y@.service is enabled/created. The timer then will trigger the corresponding tedge-cert-renewer-c8y@.service which then does the actual certificate renewal commands for the given cloud profile.

Note: You can manually enable and start the renewal process for a given Cumulocity cloud profile using the following commands:

systemctl enable tedge-cert-renewer-c8y@second.timer
systemctl start tedge-cert-renewer-c8y@second.timer

The PR also included an extension to the existing cloud profiles documentation to provide an end-to-end example of how to setup a second connection and going into some details about why (to reflect a customer scenario).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller added the theme:c8y Theme: Cumulocity related topics label Sep 17, 2025
@reubenmiller reubenmiller force-pushed the feat-cloud-profile-cert-renewal-service branch from d050034 to 74e8c05 Compare September 17, 2025 13:22
@reubenmiller reubenmiller marked this pull request as ready for review September 17, 2025 13:23
@reubenmiller reubenmiller force-pushed the feat-cloud-profile-cert-renewal-service branch from 74e8c05 to 15a133d Compare September 17, 2025 14:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 17, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
694 0 3 694 100 2h10m11.259413s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new doc is really helpful. One point is missing, though.

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the feat-cloud-profile-cert-renewal-service branch from 1ad5e1a to f9d7290 Compare September 18, 2025 11:09
@reubenmiller reubenmiller added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Sep 18, 2025
Merged via the queue into thin-edge:main with commit b839dab Sep 18, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:c8y Theme: Cumulocity related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants