Skip to content

test: refactor pkcs11 tests#3771

Merged
reubenmiller merged 4 commits intothin-edge:mainfrom
reubenmiller:test-pkcs11-refactor
Aug 27, 2025
Merged

test: refactor pkcs11 tests#3771
reubenmiller merged 4 commits intothin-edge:mainfrom
reubenmiller:test-pkcs11-refactor

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Aug 27, 2025

Proposed changes

Minor improvements to some pkcs11 tests to improve the readability and remove the need for some custom keywords.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added theme:testing Theme: Testing skip-release-notes Don't include the ticket in the auto generated release notes labels Aug 27, 2025
@reubenmiller reubenmiller mentioned this pull request Aug 27, 2025
Merged
13 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
684 0 3 684 100 2h2m50.893347999s

rina23q
rina23q approved these changes Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only cosmetic comments.

@reubenmiller
allow users to set csr path when register device with Cumulocity CA
4d42aae 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
add new keyword for pkcs11 tests
d6cb317 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
use the user-given token label when creating the private key
7b17835 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
update auto formatting
a5870f1 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller enabled auto-merge August 27, 2025 13:57
@reubenmiller reubenmiller added this pull request to the merge queue Aug 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Aug 27, 2025
Merged via the queue into thin-edge:main with commit 8ac829e Aug 27, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rina23q rina23q rina23q approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@Bravo555 Bravo555 Awaiting requested review from Bravo555 Bravo555 is a code owner

Assignees

No one assigned

Labels

skip-release-notes Don't include the ticket in the auto generated release notes theme:testing Theme: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @rina23q