Skip to content

feat: include mosquitto configuration in diagnostic collection#3769

Merged
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:feat-collect-mosquitto-config
Aug 22, 2025
Merged

feat: include mosquitto configuration in diagnostic collection#3769
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:feat-collect-mosquitto-config

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Aug 22, 2025

Proposed changes

To aid with diagnosing mosquitto configuration related issues, the following files/folders are now included:

  • /etc/mosquitto/mosquitto.conf
  • /etc/mosquitto/conf.d/
  • /etc/tedge/mosquitto-conf/

Also if the tree command is available, a full directory listing of the /etc/mosquitto folder is also included.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested review from a team and Bravo555 as code owners August 22, 2025 12:16
@reubenmiller reubenmiller force-pushed the feat-collect-mosquitto-config branch from 77b333a to bf69371 Compare August 22, 2025 12:17
@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Aug 22, 2025
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
681 0 3 681 100 2h1m38.983878999s

Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller added this pull request to the merge queue Aug 22, 2025
Merged via the queue into thin-edge:main with commit e35fbef Aug 22, 2025
32 of 33 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants