Skip to content

test: start tedge-agent after the inventory.json file#3765

Closed
reubenmiller wants to merge 1 commit intothin-edge:mainfrom
reubenmiller:test-start-agent-after-inventory-json-edit
Closed

test: start tedge-agent after the inventory.json file#3765
reubenmiller wants to merge 1 commit intothin-edge:mainfrom
reubenmiller:test-start-agent-after-inventory-json-edit

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Aug 21, 2025

Proposed changes

Fix a flaky test due a race condition where the tedge-agent is starting up at the same time the inventory.json is being edited which results in the inventory.json being sometimes ignored.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3764

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
test: start tedge-agent after the inventory.json file
180dc65 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from a team as a code owner August 21, 2025 12:16
@reubenmiller reubenmiller added skip-release-notes Don't include the ticket in the auto generated release notes flaky test Label given to flaky or otherwise faulty tests labels Aug 21, 2025
@reubenmiller reubenmiller mentioned this pull request Aug 21, 2025
Merged
11 tasks
rina23q
rina23q approved these changes Aug 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller
Copy link
Copy Markdown
Contributor Author

reubenmiller commented Aug 21, 2025

Closing as it resolved by #3755 (which was merge ~2 hours ago)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
680 0 3 680 100 1h52m11.054849999s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rina23q rina23q rina23q approved these changes

Assignees

No one assigned

Labels

flaky test Label given to flaky or otherwise faulty tests skip-release-notes Don't include the ticket in the auto generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @rina23q