Skip to content

ci: workaround cargo-udeps failure#3759

Merged
Bravo555 merged 1 commit intothin-edge:mainfrom
Bravo555:ci/fix-udeps
Aug 14, 2025
Merged

ci: workaround cargo-udeps failure#3759
Bravo555 merged 1 commit intothin-edge:mainfrom
Bravo555:ci/fix-udeps

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented Aug 14, 2025

Proposed changes

cargo-udeps is failing with:

error[E0275]: overflow evaluating the requirement `{async fn body of try_exists<&std::path::Path>()}: std::marker::Send`
     |
     = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`c8y_mapper_ext`)
note: required because it appears within the type `impl std::future::Future<Output = Result<bool, std::io::Error>>`
    --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.45.0/src/fs/try_exists.rs:25:1
     |
  25 | pub async fn try_exists(path: impl AsRef<Path>) -> io::Result<bool> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: required because it's used within this `async` fn body
    --> /home/runner/work/thin-edge.io/thin-edge.io/crates/common/tedge_utils/src/file.rs:123:58
     |
 123 |   pub async fn path_exists(path: impl AsRef<Path>) -> bool {
     |  __________________________________________________________^
 124 | |     tokio::fs::try_exists(path).await.unwrap_or(false)
 125 | | }
     | |_^
note: required because it's used within this `async` fn body
    --> /home/runner/work/thin-edge.io/thin-edge.io/crates/common/tedge_utils/src/file.rs:289:75
     |
 289 |       async fn create_directory(&self, dir: &Path) -> Result<(), FileError> {
     |  ___________________________________________________________________________^
 290 | |         match dir.parent() {
 291 | |             None => return Ok(()),
 292 | |             Some(parent) => {
...    |
 322 | |     }
     | |_____^
     = note: required for `Unique<impl std::future::Future<Output = Result<(), FileError>>>` to implement `std::marker::Send`

I think it's because of some sort of regression in the current nightly, so for now pin nightly version to an earlier version I tried locally and it seemed to work.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555 Bravo555 added the ci/cd Repository management and pipeline topics label Aug 14, 2025
@Bravo555 Bravo555 temporarily deployed to Test Pull Request August 14, 2025 08:26 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
677 0 3 677 100 1h47m44.243128999s

Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several similar reports in the past as well: rust-lang/rust#118476 but without any concrete resolution. So, this is fine for now.

I'd just suggest that you create another PR that just undoes these changes and keep it in the PR queue. We'll merge it once the issue is resolved in some upcoming nightly.

@Bravo555 Bravo555 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into thin-edge:main with commit bb8331c Aug 14, 2025
34 checks passed
@Bravo555 Bravo555 deleted the ci/fix-udeps branch August 14, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Repository management and pipeline topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants