Proposed changes

Create a TedgeP11Service trait for a standard interface implemented by both Cryptoki (direct interaction with P11 modules) and TedgeP11Client.

In #3709, to create keys we can use TedgeP11Client or Cryptoki directly. However, to not have to branch unnecessarily, we'd like these both to have the same interface for creating keys. With previous design this was not possible, as the only trait we had was TedgeP11Signer which represented an already present signing key located on the token, but we wanted to create a new one.

The new TedgeP11Service (name reused from a previous trait) is the main top-level trait for all P11-related operations (not only signing, but in #3709 also creating new keys, and in the future maybe also listing all the keys on the token), implemented both by Cryptoki and TedgeP11Client.

One additional advantage is now, TedgeP11Server uses Cryptoki using its TedgeP11Service API the same as we would directly by other callers, so we achieved some additional deduplication.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
• I ran just format as mentioned in CODING_GUIDELINES
• I used just check as mentioned in CODING_GUIDELINES
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments