Skip to content

fix: Restore WARN log level for tedge#3741

Merged
Bravo555 merged 1 commit intothin-edge:mainfrom
Bravo555:fix/tedge-correct-log-level
Jul 23, 2025
Merged

fix: Restore WARN log level for tedge#3741
Bravo555 merged 1 commit intothin-edge:mainfrom
Bravo555:fix/tedge-correct-log-level

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented Jul 23, 2025

Proposed changes

Restore previous default log level for tedge, i.e. WARN. tedge uses that because INFO is too noisy for commands like tedge mqtt pub/sub

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555
fix: restore correct log level for tedge
10bef88 
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 temporarily deployed to Test Pull Request July 23, 2025 08:14 — with GitHub Actions Inactive
didier-wenzek
didier-wenzek approved these changes Jul 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/main.rs 80.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bravo555 Bravo555 enabled auto-merge July 23, 2025 08:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
666 0 3 666 100 1h54m25.631205999s

@Bravo555 Bravo555 added this pull request to the merge queue Jul 23, 2025
Merged via the queue into thin-edge:main with commit 587a1bb Jul 23, 2025
34 checks passed
@reubenmiller reubenmiller added the theme:cli Theme: cli related topics label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

theme:cli Theme: cli related topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bravo555 @didier-wenzek @reubenmiller