fix: continue to de-duplicate incoming operations once operation is complete#3728
Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom Jul 11, 2025
Conversation
…omplete Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
didier-wenzek
approved these changes
Jul 11, 2025
Contributor
didier-wenzek
left a comment
There was a problem hiding this comment.
Approved. Thank you for fixing that race condition.
Having this very specific and local fix is okay for now.
However, I don't think this is the only place we have to sync local and remote states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix a flaky system test caused by duplicate operations being executed by the mapper.
The reason why the existing de-duplication didn't work is that the operation had been completed locally before the operation notification was received for a second time from Cumulocity. Since the command was no longer "active", the mapper totally ignored the fact the operation has already been executed.
This PR adds a new
recently_completed_commandsstore to the mapper, which stores the completed command IDs for ~1 hour to cope with this race condition where the Cumulocity operation status takes some time to update.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments