test: refactor test setup#3712
Merged
reubenmiller merged 6 commits intothin-edge:mainfrom Jun 27, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
5bf9572 to
7193c86
Compare
7193c86 to
2be3e1b
Compare
2be3e1b to
3487271
Compare
3487271 to
47f237a
Compare
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
… due to removing the local-ca option Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
47f237a to
fcc2009
Compare
didier-wenzek
approved these changes
Jun 27, 2025
| Test Setup | ||
| ${DEVICE_SN}= Setup skip_bootstrap=True | ||
| Execute Command ./bootstrap.sh | ||
| ${DEVICE_SN}= Setup |
Contributor
There was a problem hiding this comment.
I believe this skip-then-execute pattern has been a consequence of a lack of understanding of the bootstrap related features. To be honest, I did the same, i.e. blinding copy-pasting tests to build my own setup.
I do think the revised Setup will really help read and write test specific setup.
Contributor
Author
There was a problem hiding this comment.
Though it could of also developed over time, since we changed some of the defaults for using a secure local MQTT broker setup. But all of this is fairly normal, so good to clean things up from time to time.
Bravo555
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactoring the system tests to improve the setting
Setupkeyword improvementsregister,register_usingandconnectbootstrap_args=Setup(if users need to customize everything)Example usage of Setup
Below shows some common usages
Types of changes
Paste Link to the issue
#3708
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments