Skip to content

test: fix system test formatting and linting#3711

Merged
reubenmiller merged 7 commits intothin-edge:mainfrom
reubenmiller:chore-rf-framework-linting
Jun 27, 2025
Merged

test: fix system test formatting and linting#3711
reubenmiller merged 7 commits intothin-edge:mainfrom
reubenmiller:chore-rf-framework-linting

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Jun 26, 2025 •
edited
Loading

Proposed changes

Improve the linting and formatting of the RobotFramework library used within the system tests.

  • Run pylint on the system test library (previously only the system tests were linted)
  • Run formatting on system test library
  • Address linting issues (many type annotation fixes, and missing doc strings)
  • Update test dev dependencies (black, pylint etc.)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 26, 2025 11:27 — with GitHub Actions Inactive
@reubenmiller reubenmiller changed the title chore: fix system test formatting and lintint chore: fix system test formatting and linting Jun 26, 2025
@reubenmiller reubenmiller added the theme:testing Theme: Testing label Jun 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 26, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
652 0 3 652 100 1h54m27.224679s

@reubenmiller reubenmiller mentioned this pull request Jun 26, 2025
Merged
11 tasks
@reubenmiller reubenmiller force-pushed the chore-rf-framework-linting branch from 8a178ae to 107f6ff Compare June 27, 2025 06:36
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 27, 2025 06:36 — with GitHub Actions Inactive
@reubenmiller reubenmiller force-pushed the chore-rf-framework-linting branch from 107f6ff to 08df3b6 Compare June 27, 2025 08:22
@reubenmiller reubenmiller force-pushed the chore-rf-framework-linting branch from 08df3b6 to efb6ee9 Compare June 27, 2025 08:23
@reubenmiller
update testing libraries
e015586 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
fix type annotations and linting warnings
e661605 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
run formatting/linting on test library as well
96a91d9 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
update testing dev libraries
5eb5ffc 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
add pylint rules
8fb2ad1 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
apply linting and formatting fixes
452bca6 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller
fix linting errors is tasks.py
1e3c0a5 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the chore-rf-framework-linting branch from 4a55e37 to 1e3c0a5 Compare June 27, 2025 09:45
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 27, 2025 09:45 — with GitHub Actions Inactive
@reubenmiller reubenmiller marked this pull request as ready for review June 27, 2025 09:48
@reubenmiller reubenmiller requested review from a team, albinsuresh and jarhodes314 as code owners June 27, 2025 09:48
@reubenmiller reubenmiller changed the title chore: fix system test formatting and linting test: fix system test formatting and linting Jun 27, 2025
Bravo555
Bravo555 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't thoroughly tested all the changes in ThinEdgeIO.py, but I assume the changes are fine if all the tests keep working. The rest is just automatic changes made by the reformatters, so LGTM.

tests/RobotFramework/.pylintrc
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Was this automatically generated and if not, what's the source? Just curious.

Copy link
Copy Markdown
Contributor Author

@reubenmiller reubenmiller Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was auto generated first, using pylint, and then customized to disable some rules which aren't important for the project (e.g. max-line-count etc.)

@reubenmiller reubenmiller added this pull request to the merge queue Jun 27, 2025
Merged via the queue into thin-edge:main with commit 4b02fbf Jun 27, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bravo555 Bravo555 Bravo555 approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees

No one assigned

Labels

theme:testing Theme: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @Bravo555