Skip to content

tests: improve log assertion by filtering logs by time#3705

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-improve-log-assertion
Jun 24, 2025
Merged

tests: improve log assertion by filtering logs by time#3705
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-improve-log-assertion

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Jun 24, 2025

Proposed changes

Fix a flaky test which was most likely caused by log entries not being present within the last 30 entries. Using a time filter should increase the likelihood of the test capturing the required log entry.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3704

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested a review from a team as a code owner June 24, 2025 06:54
@reubenmiller reubenmiller force-pushed the test-improve-log-assertion branch from 76cd090 to 44953b3 Compare June 24, 2025 06:54
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 24, 2025 06:54 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the flaky test Label given to flaky or otherwise faulty tests label Jun 24, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 24, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
652 0 3 652 100 1h50m37.371206s

didier-wenzek
didier-wenzek approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller
improve log assertion by filtering logs by time
2e7a215 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the test-improve-log-assertion branch from 44953b3 to 2e7a215 Compare June 24, 2025 07:56
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 24, 2025 07:56 — with GitHub Actions Inactive
albinsuresh
albinsuresh approved these changes Jun 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Jun 24, 2025
Merged via the queue into thin-edge:main with commit 5def2ee Jun 24, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albinsuresh albinsuresh albinsuresh approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees

No one assigned

Labels

flaky test Label given to flaky or otherwise faulty tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reubenmiller @albinsuresh @didier-wenzek