Skip to content

fix: add connection timeout when connecting to the local broker#3702

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-jwt-mqtt-connect-timeout
Jun 24, 2025
Merged

fix: add connection timeout when connecting to the local broker#3702
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-jwt-mqtt-connect-timeout

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Add a timeout when trying to. connect to the local mqtt broker when fetching a jwt in the c8y-remote-access-plugin.

This prevents the c8y-remote-access-plugin from an infinite loop if it is misconfigured or does not have the correct credentials to connect to the local MQTT broker.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3660

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Resolves thin-edge#3660

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 23, 2025 16:52 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Jun 23, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/c8y_api/src/http_proxy.rs 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
651 0 3 651 100 1h52m49.64467s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Jun 24, 2025
Merged via the queue into thin-edge:main with commit 3171233 Jun 24, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants